It looks functional and no longer leaks so I don't see the need for a plumber. Changing the disposal when it breaks will likly require replacing all the pipe in the pic but that;s often true.

does it make sense to ask him to redo the rest of this masterpiece so that there are not so many pieces, and so that it doesn't take up so much room?

While it may not be pretty, there's really nothing wrong with it. It's under your sink not displayed above your fireplace, so who cares what it looks like?
And I don't see how redoing it will save you any room. It isn't like there are any extra twists and turns that you can get rid of.

If it ain't broke, don't fix it.

Definitely not a work of art, even by Modern Art standards.

You will eventually want to fix it because you will want to sell the condo sometime. However, if it's not leaking... you may want to focus on other things.

I pretty strongly disagree with the "There's nothing wrong with it" statement above, but it wouldn't be on my priority list.

How did this ever get past city code inspection?

I pretty strongly disagree with the "There's nothing wrong with it" statement above

Can you be more specific? What is wrong with it other than it's ugly?

Hi, jakethewonderdog.

"How did this ever get past city code inspection?"

The rumor is that there is only one building inspector for the whole state.

To start with, there must be a baffled waste tee between the two bowls of the sink. In addition, the trap is glued on one side and detachable on the other (how did they even do that?) It should be detachable. There are probably more issues, but those two jump right out there. The creative use of fittings, multiple short pieces of pipe joined together, etc. are all things that shouldn't have happened.

Ugly isn't a code violation, but poor workmanship can be. We want to be sure that when giving advice, we call out poor workmanship -- and this certainly qualifies. It's not just "does the water end up where it's supposed to be?"

If I were a buyer or an inspector, if I were to see something like that I would get out the magnifying glass and look over everything... The owner may not be able to fix everything, but he/she can un-cobble obvious problems as they go.

Note my similar response to the water heater repair question on here: when it becomes obvious that something was so poorly done, the entire job becomes suspect.

Thanks for all the replies. I'll take the advice to lower it on my priority list. If I need to call a plumber in the future for something else, that's the time to have them tweak the trap.

It never occurred to me that it might be okay to leave it as is. Since the main function of a trap is to provide a water barrier to sewer smells, not being able to remove it probably isn't a huge deal.

Thanks again!